update the hive workaround to support the new hive #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -102,7 +102,7 @@ | |||
| File Should Not Be Empty ${osp_clouds_yaml} | |||
| ${shell_script} = Catenate | |||
| ... ${CURDIR}/OSP/create_fips.sh ${cluster_name} ${infrastructure_configurations}[base_domain] | |||
| ... ${infrastructure_configurations}[osp_network] ${infrastructure_configurations}[osp_cloud_name] ${artifacts_dir}/ | |||
| ... ${infrastructure_configurations}[osp_network] ${infrastructure_configurations}[osp_cloud_name] ${artifacts_dir}/ | |||
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning
| ${claim_status} = Run Process | ||
| ... oc -n ${hive_namespace} get clusterclaim ${claim_name} -o json | jq '.status.conditions[] | select(.type\=\="ClusterRunning" and .reason\=\="Resuming")' --exit-status shell=yes | ||
| ${claim_status} = Run Process | ||
| ... oc -n ${hive_namespace} get clusterclaim ${claim_name} -o json | jq '.status.conditions[] | select(.type\=\="ClusterRunning" and (.reason\=\="Resuming" or .reason\=\="Running"))' --exit-status shell=yes |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning
related to jira ticket: RHOAIENG-3338 Signed-off-by: Kobi Hakimi <[email protected]>
kobihk
force-pushed
the
update_hive_wa_master
branch
from
ae361b8 to
0357f31
Compare
Robot Results
|
jstourac
approved these changes
Mar 13, 2024
|
manosnoam
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the old Hive the cluster status was Resuming instead of Running so we had the workaround to check that
In the new Hive this issue was fixed and the status is Running but to support both we updated the workaround
verified with old Hive:
➜ oc -n rhods get clusterclaim ods-qe-psi-03-claim -o json | jq '.status.conditions[] | select(.type=="ClusterRunning" and (.reason=="Resuming" or .reason=="Running"))' --exit-status
{
"lastProbeTime": "2024-03-05T17:38:34Z",
"lastTransitionTime": "2024-03-05T17:38:34Z",
"message": "Waiting for cluster to be running",
"reason": "Resuming",
"status": "False",
"type": "ClusterRunning"
}
➜
verified with the New Hive:
➜ oc -n rhoai get clusterclaim ods-qe-psi-04-claim -o json | jq '.status.conditions[] | select(.type=="ClusterRunning" and (.reason=="Resuming" or .reason=="Running"))' --exit-status
{
"lastProbeTime": "2024-03-13T11:42:33Z",
"lastTransitionTime": "2024-03-13T11:42:33Z",
"message": "Cluster is running",
"reason": "Running",
"status": "True",
"type": "ClusterRunning"
}
➜
related to jira ticket: RHOAIENG-3338